Page MenuHomePhabricator
Differential D12487

Move pindexBestInvalid and pindexBestParked to ChainstateManager
ClosedPublic
Actions

Authored by PiRK on Nov 14 2022, 15:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCcf55baaecdbc: Move pindexBestInvalid and pindexBestParked to ChainstateManager
Summary

A private member is better than a global.

This concludes backport of core#23785
https://github.com/bitcoin/bitcoin/pull/23785/commits/fab6d6b2d154893ab422dda87f3535d42c3e06f4

Depends on D12486

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Nov 14 2022, 15:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 14 2022, 15:24
PiRK requested review of this revision.Nov 14 2022, 15:24
teamcity edited the summary of this revision. (Show Details)Nov 14 2022, 15:24
PiRK updated this revision to Diff 36295.Nov 14 2022, 15:27
PiRK edited the summary of this revision. (Show Details)

don't forget to also reset m_best_parked on ChainstateLanger::Unload()

Harbormaster completed remote builds in B20910: Diff 36286.Nov 14 2022, 15:48
Harbormaster completed remote builds in B20911: Diff 36295.Nov 14 2022, 15:52
PiRK added a child revision: D12507: Move BlockManager to node/blockstorage.Nov 16 2022, 10:04
Fabien accepted this revision.Nov 16 2022, 11:03
This revision is now accepted and ready to land.Nov 16 2022, 11:03
Closed by commit rABCcf55baaecdbc: Move pindexBestInvalid and pindexBestParked to ChainstateManager (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyNov 16 2022, 13:59
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCcf55baaecdbc: Move pindexBestInvalid and pindexBestParked to ChainstateManager.

Revision Contents
Changeset List

PathSize
src/
5 lines
52 lines

Diff 36295

View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...