Page MenuHomePhabricator

[Cashtab] [ECPair from wif p4] Message signing bug fix
AbandonedPublic

Authored by bytesofman on Nov 15 2022, 11:37.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Summary

T2730

Depends on D12490

Now that we have a function to get EC Pair from Wif, we can also deprecate bchObj.BitcoinCash.signMessageWithPrivKey

This diff patches a bug in that this function is treated async but it is not

Test Plan

Review here to confirm the function is not async: https://github.com/Permissionless-Software-Foundation/bch-js/blob/master/src/bitcoincash.js#L150
npm start
sign and verify a msg

Diff Detail

Repository
rABC Bitcoin ABC
Branch
local-ecpair
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20916
Build 41489: Build Diffcashtab-tests
Build 41488: arc lint + arc unit