Differential D12626

[Cashtab] [Deprecate BCH msg signing p1/3] Correct async bug
ClosedPublic
Actions

Authored by bytesofman on Nov 25 2022, 12:48.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC47df76febe57: [Cashtab] [Deprecate BCH msg signing p1/3] Correct async bug

Summary

T2730

Now that we have a function to get EC Pair from Wif, we can also deprecate bchObj.BitcoinCash.signMessageWithPrivKey

This diff patches a bug in that this function is treated async but it is not

Test Plan

Review here to confirm the function is not async: https://github.com/Permissionless-Software-Foundation/bch-js/blob/master/src/bitcoincash.js#L150
npm start
sign and verify a msg

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 25 2022, 12:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2022, 12:48

bytesofman requested review of this revision.Nov 25 2022, 12:48

bytesofman mentioned this in D12491: [Cashtab] [ECPair from wif p4] Message signing bug fix.Nov 25 2022, 12:48

bytesofman added a child revision: D12627: [Cashtab] [Deprecate BCH msg signing p2/3] Implement local msg signing.Nov 25 2022, 12:50

Harbormaster completed remote builds in B21140: Diff 36633.Nov 25 2022, 13:01

emack accepted this revision.Nov 26 2022, 03:50

This revision is now accepted and ready to land.Nov 26 2022, 03:50

rebase

This revision was landed with ongoing or failed builds.Nov 26 2022, 06:22

Closed by commit rABC47df76febe57: [Cashtab] [Deprecate BCH msg signing p1/3] Correct async bug (authored by bytesofman). · Explain Why

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC47df76febe57: [Cashtab] [Deprecate BCH msg signing p1/3] Correct async bug.

Harbormaster completed remote builds in B21158: Diff 36665.Nov 26 2022, 06:24

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

SignVerifyMsg/

SignVerifyMsg.js

11 lines

Diff 36669

View Options

web/cashtab/src/components/SignVerifyMsg/SignVerifyMsg.js

[Cashtab] [Deprecate BCH msg signing p1/3] Correct async bugClosedPublicActions