Page MenuHomePhabricator
Differential D12628

[Cashtab] [Deprecate BCH msg signing p3/3] Deprecate msg signing with bchObj
ClosedPublic
Actions

Authored by bytesofman on Nov 25 2022, 12:53.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC439e9b6587bb: [Cashtab] [Deprecate BCH msg signing p3/3] Deprecate msg signing with bchObj
Summary

T2730

Depends on D12627

Replace legacy signing method with updated local method. Since BCH param is now unused, it must be removed in this diff from this component and snapshot tests to prevent build errors.

Test Plan

npm start, sign and verify some msgs, confirm that ElectrumABC is also able to verify the msgs

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 25 2022, 12:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2022, 12:53
bytesofman requested review of this revision.Nov 25 2022, 12:53
bytesofman mentioned this in D12493: [Cashtab] [ECPair from wif p6] Deprecate BCH msg signing.Nov 25 2022, 12:53
Harbormaster completed remote builds in B21142: Diff 36635.Nov 25 2022, 13:04
emack accepted this revision.Nov 26 2022, 04:24
This revision is now accepted and ready to land.Nov 26 2022, 04:24
bytesofman updated this revision to Diff 36667.Nov 26 2022, 06:18

rebase

bytesofman updated this revision to Diff 36668.Nov 26 2022, 06:18

rebase

This revision was landed with ongoing or failed builds.Nov 26 2022, 06:22
Closed by commit rABC439e9b6587bb: [Cashtab] [Deprecate BCH msg signing p3/3] Deprecate msg signing with bchObj (authored by bytesofman). · Explain Why
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC439e9b6587bb: [Cashtab] [Deprecate BCH msg signing p3/3] Deprecate msg signing with bchObj.
Harbormaster completed remote builds in B21160: Diff 36667.Nov 26 2022, 06:24
Harbormaster completed remote builds in B21161: Diff 36668.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
SignVerifyMsg/
30 lines
__tests__/
13 lines

Diff 36671

View Options

web/cashtab/src/components/SignVerifyMsg/SignVerifyMsg.js

Loading...
View Options

web/cashtab/src/components/SignVerifyMsg/__tests__/SignVerifyMsg.test.js

Loading...