Page MenuHomePhabricator
Differential D12627

[Cashtab] [Deprecate BCH msg signing p2/3] Implement local msg signing
ClosedPublic
Actions

Authored by bytesofman on Nov 25 2022, 12:50.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC09178e18c68e: [Cashtab] [Deprecate BCH msg signing p2/3] Implement local msg signing
Summary

T2730

Depends on D12626

Implement message signing without use of the BCH param. Compare new method to legacy method.

Test Plan

npm start and sign some msgs. Look for The signatures match in the dev console.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 25 2022, 12:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2022, 12:50
bytesofman requested review of this revision.Nov 25 2022, 12:50
bytesofman mentioned this in D12492: [Cashtab] [ECPair from wif p5] Implement local msg signing.Nov 25 2022, 12:51
bytesofman added a child revision: D12628: [Cashtab] [Deprecate BCH msg signing p3/3] Deprecate msg signing with bchObj.Nov 25 2022, 12:53
Harbormaster completed remote builds in B21141: Diff 36634.Nov 25 2022, 13:01
emack accepted this revision.Nov 26 2022, 04:07
This revision is now accepted and ready to land.Nov 26 2022, 04:07
bytesofman updated this revision to Diff 36666.Nov 26 2022, 06:18

rebase

This revision was landed with ongoing or failed builds.Nov 26 2022, 06:22
Closed by commit rABC09178e18c68e: [Cashtab] [Deprecate BCH msg signing p2/3] Implement local msg signing (authored by bytesofman). · Explain Why
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC09178e18c68e: [Cashtab] [Deprecate BCH msg signing p2/3] Implement local msg signing.
Harbormaster completed remote builds in B21159: Diff 36666.Nov 26 2022, 06:24

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
SignVerifyMsg/
23 lines

Diff 36670

View Options

web/cashtab/src/components/SignVerifyMsg/SignVerifyMsg.js

Loading...