[Cashtab] [Extension] [Code cleanup p4] Update comments and function name for triggerUi
AbandonedPublic
Actions

Authored by bytesofman on Nov 15 2022, 14:40.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

T2751

Depends on D12503

Originally, triggerUi was modeled on a metamask generalist function. However in Cashtab it is only used for opening a window to send a prepopulated xec tx.

Update the comments and function name to reflect this.

Test Plan

Same as D12502

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20957
Build 41570: Build Diff	cashtab-tests
Build 41569: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 15 2022, 14:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2022, 14:40

bytesofman requested review of this revision.Nov 15 2022, 14:40

Harbormaster completed remote builds in B20929: Diff 36314.Nov 15 2022, 14:44

bytesofman added a child revision: D12505: [Cashtab] [Extension] [Code cleanup p5] Update comments and function name for triggerApprovalModal.Nov 15 2022, 14:47

rebase

Harbormaster completed remote builds in B20957: Diff 36353.Nov 16 2022, 17:24

bytesofman abandoned this revision.Nov 21 2022, 10:11

Revision Contents
Changeset List

Path

Size

web/

cashtab/

extension/

src/

background.js

22 lines

Diff 36353

View Options

web/cashtab/extension/src/background.js

[Cashtab] [Extension] [Code cleanup p4] Update comments and function name for triggerUiAbandonedPublicActions