Differential D12535

scripted-diff: Remove redundant sync_all and sync_blocks
ClosedPublic
Actions

Authored by Fabien on Nov 18 2022, 16:53.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCec049aa03927: scripted-diff: Remove redundant sync_all and sync_blocks

Summary

The sync calls are redundant after a call to generate, because generate
already syncs itself.

Completes backport of core#23474:
https://github.com/bitcoin/bitcoin/pull/23474/commits/fa974f1f1417a536636347072e86bcb54a4c909c

Depends on D12533.

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR23474_p2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20986
Build 41628: Build Diff	build-debug · build-diff · build-without-wallet · build-clang-tidy · build-clang
Build 41627: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 18 2022, 16:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 18 2022, 16:53

Fabien requested review of this revision.Nov 18 2022, 16:53

teamcity edited the summary of this revision. (Show Details)Nov 18 2022, 16:54

PiRK accepted this revision.Nov 18 2022, 17:04

This revision is now accepted and ready to land.Nov 18 2022, 17:04

Harbormaster completed remote builds in B20986: Diff 36400.Nov 18 2022, 17:06

Closed by commit rABCec049aa03927: scripted-diff: Remove redundant sync_all and sync_blocks (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyNov 18 2022, 20:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCec049aa03927: scripted-diff: Remove redundant sync_all and sync_blocks.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-parkedchain.py

25 lines

abc_p2p_avalanche_peer_discovery.py

1 line

feature_coinstatsindex.py

3 lines

interface_rest.py

10 lines

interface_zmq.py

4 lines

mempool_packages.py

3 lines

mining_getblocktemplate_longpoll.py

1 line

1 line

1 line

1 line

2 lines

rpc_createmultisig.py

2 lines

rpc_fundrawtransaction.py

12 lines

rpc_getblockstats.py

1 line

rpc_psbt.py

5 lines

rpc_rawtransaction.py

3 lines

rpc_txoutproof.py

2 lines

wallet_abandonconflict.py

1 line

wallet_address_types.py

2 lines

10 lines

6 lines

6 lines

1 line

6 lines

2 lines

wallet_import_rescan.py

1 line

wallet_importdescriptors.py

3 lines

wallet_importprunedfunds.py

2 lines

wallet_keypool_topup.py

1 line

wallet_listreceivedby.py

5 lines

wallet_listsinceblock.py

2 lines

wallet_listtransactions.py

1 line

wallet_reorgsrestore.py

1 line

wallet_send.py

2 lines

wallet_txn_clone.py

1 line

wallet_txn_doublespend.py

1 line

Diff 36400

View Options

test/functional/abc-parkedchain.py

View Options

test/functional/abc_p2p_avalanche_peer_discovery.py

View Options

test/functional/feature_coinstatsindex.py

View Options

test/functional/interface_rest.py

View Options

test/functional/interface_zmq.py

View Options

test/functional/mempool_packages.py

View Options

test/functional/mining_getblocktemplate_longpoll.py

View Options

test/functional/p2p_blockfilters.py

View Options

test/functional/p2p_ibd_txrelay.py

View Options

test/functional/p2p_permissions.py

View Options

test/functional/p2p_sendheaders.py

View Options

test/functional/rpc_createmultisig.py

View Options

test/functional/rpc_fundrawtransaction.py

View Options

test/functional/rpc_getblockstats.py

View Options

test/functional/rpc_psbt.py

View Options

test/functional/rpc_rawtransaction.py

View Options

test/functional/rpc_txoutproof.py

View Options

test/functional/wallet_abandonconflict.py

View Options

test/functional/wallet_address_types.py

View Options

test/functional/wallet_avoidreuse.py

View Options

test/functional/wallet_backup.py

View Options

test/functional/wallet_balance.py

View Options

test/functional/wallet_basic.py

View Options

test/functional/wallet_groups.py

View Options

test/functional/wallet_hd.py

View Options

test/functional/wallet_import_rescan.py

View Options

test/functional/wallet_importdescriptors.py

View Options

test/functional/wallet_importprunedfunds.py

View Options

test/functional/wallet_keypool_topup.py

View Options

test/functional/wallet_listreceivedby.py

View Options

test/functional/wallet_listsinceblock.py

View Options

test/functional/wallet_listtransactions.py

View Options

test/functional/wallet_reorgsrestore.py

View Options

test/functional/wallet_send.py

View Options

test/functional/wallet_txn_clone.py

View Options

test/functional/wallet_txn_doublespend.py

scripted-diff: Remove redundant sync_all and sync_blocksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36400

test/functional/abc-parkedchain.py

test/functional/abc_p2p_avalanche_peer_discovery.py

test/functional/feature_coinstatsindex.py

test/functional/interface_rest.py

test/functional/interface_zmq.py

test/functional/mempool_packages.py

test/functional/mining_getblocktemplate_longpoll.py

test/functional/p2p_blockfilters.py

test/functional/p2p_ibd_txrelay.py

test/functional/p2p_permissions.py

test/functional/p2p_sendheaders.py

test/functional/rpc_createmultisig.py

test/functional/rpc_fundrawtransaction.py

test/functional/rpc_getblockstats.py

test/functional/rpc_psbt.py

test/functional/rpc_rawtransaction.py

test/functional/rpc_txoutproof.py

test/functional/wallet_abandonconflict.py

test/functional/wallet_address_types.py

test/functional/wallet_avoidreuse.py

test/functional/wallet_backup.py

test/functional/wallet_balance.py

test/functional/wallet_basic.py

test/functional/wallet_groups.py

test/functional/wallet_hd.py

test/functional/wallet_import_rescan.py

test/functional/wallet_importdescriptors.py

test/functional/wallet_importprunedfunds.py

test/functional/wallet_keypool_topup.py

test/functional/wallet_listreceivedby.py

test/functional/wallet_listsinceblock.py

test/functional/wallet_listtransactions.py

test/functional/wallet_reorgsrestore.py

test/functional/wallet_send.py

test/functional/wallet_txn_clone.py

test/functional/wallet_txn_doublespend.py

scripted-diff: Remove redundant sync_all and sync_blocks
ClosedPublic
Actions

Revision Contents
Changeset List