Differential D12565

node/chainstate: Decouple from ArgsManager
ClosedPublic
Actions

Authored by Fabien on Nov 22 2022, 09:36.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCc899aedf2926: node/chainstate: Decouple from ArgsManager

Summary

...instead pass in only the necessary information

Partial backport of core#23280:
https://github.com/bitcoin/bitcoin/pull/23280/commits/c7a5c46e6fd6d6ff46ca7a65fc3f0fff3cbdb24e

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 22 2022, 09:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2022, 09:36

Fabien requested review of this revision.Nov 22 2022, 09:36

teamcity edited the summary of this revision. (Show Details)Nov 22 2022, 09:36

Fabien added a child revision: D12566: node/chainstate: Decouple from concept of NodeContext.Nov 22 2022, 09:37

Harbormaster completed remote builds in B21036: Diff 36473.Nov 22 2022, 09:53

PiRK accepted this revision.Nov 22 2022, 12:23

This revision is now accepted and ready to land.Nov 22 2022, 12:23

Closed by commit rABCc899aedf2926: node/chainstate: Decouple from ArgsManager (authored by Carl Dong <contact@carldong.me>, committed by Fabien). · Explain WhyNov 22 2022, 13:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc899aedf2926: node/chainstate: Decouple from ArgsManager.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

8 lines

node/

chainstate.h

8 lines

chainstate.cpp

19 lines

Diff 36492

View Options

src/init.cpp

View Options

src/node/chainstate.h

View Options

node/chainstate: Decouple from ArgsManagerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36492

src/init.cpp

src/node/chainstate.h

src/node/chainstate.cpp

node/chainstate: Decouple from ArgsManager
ClosedPublic
Actions

Revision Contents
Changeset List