while loop
ClosedPublic
Actions

Authored by Fabien on Nov 22 2022, 09:38.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC98e2e28c1a54: node/chainstate: Remove do/while loop

Summary

Partial backport of core#23280:
https://github.com/bitcoin/bitcoin/pull/23280/commits/adf4912d77496b9a243476c5944528f95641f14d?diff=split&w=1

Depends on D12568.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 22 2022, 09:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2022, 09:38

Fabien requested review of this revision.Nov 22 2022, 09:38

teamcity edited the summary of this revision. (Show Details)Nov 22 2022, 09:38

Fabien added a child revision: D12570: Split off VerifyLoadedChainstate.Nov 22 2022, 09:39

Harbormaster completed remote builds in B21040: Diff 36477.Nov 22 2022, 10:13

PiRK accepted this revision.Nov 22 2022, 12:29

This revision is now accepted and ready to land.Nov 22 2022, 12:29

TIL how to emulate goto with do {... break; ...} while(false)
https://stackoverflow.com/questions/2314066/do-whilefalse

Closed by commit rABC98e2e28c1a54: node/chainstate: Remove do/while loop (authored by Carl Dong <contact@carldong.me>, committed by Fabien). · Explain WhyNov 22 2022, 13:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC98e2e28c1a54: node/chainstate: Remove do/while loop.

Revision Contents
Changeset List

Path

Size

src/

node/

chainstate.cpp

233 lines

Diff 36496

View Options

node/chainstate: Remove do/while loopClosedPublicActions