Differential D12572

node/chainstate: Reduce coupling of LogPrintf
ClosedPublic
Actions

Authored by Fabien on Nov 22 2022, 09:40.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC9439a964d283: node/chainstate: Reduce coupling of LogPrintf

Summary

...by moving the try/catch out of LoadChainstate

Partial backport of core#23280:
https://github.com/bitcoin/bitcoin/pull/23280/commits/aad8d597890c3707ae96fdb2b9fadc270ca574dd

Depends on D12571.

Note that the extra scope will be removed in a follow up.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 22 2022, 09:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2022, 09:40

Fabien requested review of this revision.Nov 22 2022, 09:40

teamcity edited the summary of this revision. (Show Details)Nov 22 2022, 09:40

Fabien added a child revision: D12573: Move -checkblocks LogPrintf to AppInitMain.Nov 22 2022, 09:40

Harbormaster completed remote builds in B21043: Diff 36480.Nov 22 2022, 10:26

PiRK accepted this revision.Nov 22 2022, 12:49

This revision is now accepted and ready to land.Nov 22 2022, 12:49

Closed by commit rABC9439a964d283: node/chainstate: Reduce coupling of LogPrintf (authored by Carl Dong <contact@carldong.me>, committed by Fabien). · Explain WhyNov 22 2022, 13:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9439a964d283: node/chainstate: Reduce coupling of LogPrintf.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

40 lines

node/

chainstate.cpp

10 lines

Diff 36498

View Options

src/init.cpp