Page MenuHomePhabricator

[Cashtab] [BCH deprecation] [TxBuilder] Pt 8/8 - Deprecate remaining BCH.TransactionBuilder references
ClosedPublic

Authored by emack on Nov 23 2022, 23:36.

Details

Summary

T2730

Depends on D12601

This diff deprecates the remaining use of BCH-JS' transaction builder and replaces it with the local implementation for the burnToken function and unit tests.

Pt 1/8 - Localize Transaction Builder module
Pt 2/8 - Deprecate BCH.TransactionBuilder in sendXec
Pt 3/8 - Add local TxBuilder to createToken
Pt 4/8 - Deprecate BCH.TransactionBuilder in createToken
Pt 5/8 - Add local TxBuilder to sendToken
Pt 6/8 - Deprecate BCH.TransactionBuilder in sendToken
Pt 7/8 - Add local TxBuilder to burnToken
Pt 8/8 - Deprecate remaining BCH.TransactionBuilder references

Test Plan
  • grep -r 'BCH.TransactionBuilder' src/ and ensure no results
  • npm ci
  • npm test and ensure no errors with txBuilder.test.js
  • npm start
  • burn an existing token and ensure burn token tx is successfully broadcasted
  • burn a newly created token and ensure burn token tx is successfully broadcasted
  • create a new token and ensure genesis tx is still successfully broadcasted
  • send an existing token and ensure send token tx is still successfully broadcasted
  • send a newly created token and ensure send token tx is still successfully broadcasted

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txBuilder2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21098
Build 41849: Build Diffcashtab-tests
Build 41848: arc lint + arc unit