This is a backport of core#22903
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC6cfa62f5198d: Enable clang-tidy bugprone-argument-comment and fix violations
cmake .. -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DENABLE_CLANG_TIDY=ON -GNinja ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log:
[179/473] pow: testing daa_tests [180/473] Running utility command for check-pow-daa_tests [181/473] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/write_name_tests.cpp.o [182/473] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o [183/473] pow: testing eda_tests [184/473] Running utility command for check-pow-eda_tests [185/473] pow: testing grasberg_tests [186/473] Running utility command for check-pow-grasberg_tests [187/473] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o [188/473] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o [189/473] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/message_writer_tests.cpp.o [190/473] Linking CXX executable src/seeder/test/test-seeder [191/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o [192/473] seeder: testing options_tests [193/473] seeder: testing message_writer_tests [194/473] Running utility command for check-seeder-options_tests [195/473] Running utility command for check-seeder-message_writer_tests [196/473] pow: testing aserti32d_tests [197/473] Running utility command for check-pow-aserti32d_tests [198/473] Running pow test suite PASSED: pow test suite [199/473] seeder: testing p2p_messaging_tests [200/473] seeder: testing parse_name_tests [201/473] Running utility command for check-seeder-p2p_messaging_tests [202/473] Running utility command for check-seeder-parse_name_tests [203/473] seeder: testing write_name_tests [204/473] Running utility command for check-seeder-write_name_tests [205/473] Running seeder test suite PASSED: seeder test suite [206/473] Test Bitcoin RPC authentication... ... ---------------------------------------------------------------------- Ran 3 tests in 0.005s OK [207/473] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py ..... ---------------------------------------------------------------------- Ran 5 tests in 0.001s OK [208/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o [209/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o [210/473] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o [211/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o [212/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o [213/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o [214/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o [215/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o [216/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o [217/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o [218/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o [219/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o [220/473] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o [221/473] Linking CXX executable src/qt/test/test_bitcoin-qt [222/473] bitcoin-qt: testing test_bitcoin-qt [223/473] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1