Page MenuHomePhabricator
Differential D12721

rpc: use peer_id, blockhash for FetchBlock
ClosedPublic
Actions

Authored by PiRK on Dec 1 2022, 13:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9132c4dcfd68: rpc: use peer_id, blockhash for FetchBlock
Summary

This concludes backport of core#23706 and core#24806
https://github.com/bitcoin/bitcoin/pull/23706/commits/923312fbf6a89efde1739da0b7209694d4f892ba

Depends on D12720

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 1 2022, 13:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2022, 13:32
PiRK requested review of this revision.Dec 1 2022, 13:32
teamcity edited the summary of this revision. (Show Details)Dec 1 2022, 13:32
Harbormaster completed remote builds in B21305: Diff 36884.Dec 1 2022, 13:52
Fabien requested changes to this revision.Dec 1 2022, 14:57
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/blockchain.cpp
891 ↗(On Diff #36884)

There is a missing change

This revision now requires changes to proceed.Dec 1 2022, 14:57
PiRK updated this revision to Diff 36897.Dec 1 2022, 17:04

rebase and add missing change in RPC doc for blockhash param

Fabien accepted this revision.Dec 1 2022, 17:17
This revision is now accepted and ready to land.Dec 1 2022, 17:17
Harbormaster completed remote builds in B21316: Diff 36897.Dec 1 2022, 17:32
Closed by commit rABC9132c4dcfd68: rpc: use peer_id, blockhash for FetchBlock (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by PiRK). · Explain WhyDec 3 2022, 07:51
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC9132c4dcfd68: rpc: use peer_id, blockhash for FetchBlock.

Revision Contents
Changeset List

PathSize
src/
4 lines
12 lines
rpc/
16 lines
2 lines

Diff 36932

View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/client.cpp

Loading...