Page MenuHomePhabricator
Differential D12741

[Cashtab] Remove BCH param from wallet derivation p5 - Deprecate isValidBchAddress
AbandonedPublic
Actions

Authored by bytesofman on Dec 3 2022, 13:08.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

T2730

Depends on D12725

Deprecate isValidBchAddress function

Now that wallets that still have legacy bitcoincash: addresses are forced to migrate on load, do not support validation of bitcoincash: addresses

Test Plan

Review unit test mock changes and npm test
npm start
Load an unmigrated wallet and send an XEC tx
Confirm the utxo set updates so that the address: params are ecash: format on load

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-bch-from-derivewallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21337
Build 42324: Build Diffcashtab-tests
Build 42323: arc lint + arc unit

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
__mocks__/
12 lines
utils/
__mocks__/
20 lines
__tests__/
27 lines
50 lines
6 lines
45 lines

Diff 36933

View Options

web/cashtab/src/hooks/__mocks__/sendBCH.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/mockTxBuilderData.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/__tests__/validation.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...
View Options

web/cashtab/src/utils/validation.js

Loading...