Page MenuHomePhabricator
Differential D12724

[Cashtab] Remove BCH param from wallet derivation p3 - generated address should be ecash
AbandonedPublic
Actions

Authored by bytesofman on Dec 1 2022, 16:02.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Summary

T2730

Depends on D12723

Generated wallets should use ecash: format and not bitcoincash:

Note: At this point, there is some technical debt invoked by not migrating wallets that use the old format. So, later diffs in this stack will also add this feature.

Test Plan

npm start
Create a new wallet
Activate it
Receive an XEC tx
Send an XEC tx
Receive an eToken tx
Send an eToken tx

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-bch-from-derivewallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21308
Build 42266: Build Diffcashtab-tests
Build 42265: arc lint + arc unit

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
__mocks__/
10 lines
4 lines
utils/
5 lines

Diff 36888

View Options

web/cashtab/src/hooks/__mocks__/mockLegacyWallets.js

Loading...
View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...