Page MenuHomePhabricator

[Cashtab] Remove BCH param from wallet derivation p6 - Remove legacy derivation paths
AbandonedPublic

Authored by bytesofman on Dec 3 2022, 13:43.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

T2825

Depends on D12741

Remove legacy derivation paths

Note: this is a 'breaking' change for edge case wallets that could exist in the wild. This type of edge case wallet would need to have been created a couple of years ago and then never used until after this diff lands. In this case, the user may have funds on Path145 and/or Path245 but not Path1899.

Judgment call that this edge case can be safely ignored. This diff will not cause such users to lose funds.

This is not strictly related the the other diffs in this stack. However, dev decision that it is best to limit the amount of times we require all Cashtab users to migrateLegacyWallet.

Test Plan

npm start
Review dev log to see that your wallet migrated on load
Confirm it does not have Path145 or Path245 in local storage
Send an XEC tx
Send an eToken tx
Change wallets
Confirm it migrated to new structure on load
Change wallets a lot, try to break it

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-bch-from-derivewallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21338
Build 42326: Build Diffcashtab-tests
Build 42325: arc lint + arc unit