Paths

Table of Contentst

Differential D12725

[Cashtab] Remove BCH param from wallet derivation p4 - Migrate wallets without ecash: prefixed addresses to new format
AbandonedPublic
Actions

Authored by bytesofman on Dec 1 2022, 16:18.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Summary

T2730

Depends on D12724

Migrate wallets to ecash: format address

Test Plan

npm start
Open dev console
Note that migrateLegacyWallet appears
Check your wallet in storage and see that it is missing fundingAddress, legacyAddress, and slpAddress keys
Check that cashAddress is ecash: prefixed
Activate a saved wallet
Confirm the same

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove-bch-from-derivewallet

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21309
Build 42268: Build Diff	cashtab-tests
Build 42267: arc lint + arc unit

Event Timeline

bytesofman created this revision.Dec 1 2022, 16:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2022, 16:18

bytesofman requested review of this revision.Dec 1 2022, 16:18

Harbormaster completed remote builds in B21309: Diff 36889.Dec 1 2022, 16:21

emack accepted this revision.Dec 2 2022, 03:04

This revision is now accepted and ready to land.Dec 2 2022, 03:04

bytesofman added a child revision: D12741: [Cashtab] Remove BCH param from wallet derivation p5 - Deprecate isValidBchAddress.Dec 3 2022, 13:08

To be superseded by diffs coming from T2836

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

utils/

__mocks__/

mockLegacyWalletsUtils.js

42 lines

__tests__/

cashMethods.test.js

5 lines

4 lines

Diff 36889

web/cashtab/src/utils/mocks/mockLegacyWalletsUtils.js

Loading...

web/cashtab/src/utils/tests/cashMethods.test.js

Loading...

web/cashtab/src/utils/cashMethods.js

Loading...