Page MenuHomePhabricator
Differential D1279

Ensure teamcity runs more of the unit tests.
ClosedPublic
Actions

Authored by schancel on Apr 12 2018, 04:59.

Details

Reviewers
deadalnix
jasonbcox
mbhinder
Group Reviewers
Restricted Project
Commits
rSTAGING45ba86437b58: Ensure teamcity runs more of the unit tests.
rABC45ba86437b58: Ensure teamcity runs more of the unit tests.
Test Plan

Check CI build results

Diff Detail

Repository
rABC Bitcoin ABC
Branch
moar-testing
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2309
Build 2756: Bitcoin ABC Buildbot (legacy)
Build 2755: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 12 2018, 04:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2018, 04:59
teamcity added a subscriber: teamcity.Apr 12 2018, 05:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 12 2018, 05:19

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2294: Diff 3479!Apr 12 2018, 05:19
schancel updated this revision to Diff 3480.Apr 12 2018, 06:11

Fix build of secp256k1 and univalue

teamcity added a comment.Apr 12 2018, 06:13

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2295: Diff 3480.Apr 12 2018, 06:36
teamcity added a comment.Apr 12 2018, 06:36

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix added a comment.Apr 12 2018, 12:39

1/ What about leveldb ?
2/ This doesn't seems like it'll fail if tests or even the build fails

mbhinder added a comment.Apr 12 2018, 18:49
In D1279#25229, @deadalnix wrote:

1/ What about leveldb ?
2/ This doesn't seems like it'll fail if tests or even the build fails

It is "set -e" at the top, I believe it'll fail?

@schancel The code LGTM, don't have context about what it is supposed to cover.

schancel added a comment.Apr 12 2018, 21:19

Leveldb seems to be built in a strange way. No makefiles are being generated by ../configure

schancel updated this revision to Diff 3496.Apr 13 2018, 00:47

Add leveldb tests

teamcity added a comment.Apr 13 2018, 00:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 13 2018, 01:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2309: Diff 3496!Apr 13 2018, 01:01
deadalnix added a comment.Apr 13 2018, 13:32

This approach is wrong, the leveldb thing was kind of a tell. This will lead to have to maintain a list of tests that will inevitably get out of sync and have pieces missing. Why isn't it possible to use make check ? If there is something missing from there, then it's probably a better idea to modify it to do what it's not doing properly now rather than create a list of test to maintain.

schancel added a comment.Apr 19 2018, 23:12
In D1279#25421, @deadalnix wrote:

This approach is wrong, the leveldb thing was kind of a tell. This will lead to have to maintain a list of tests that will inevitably get out of sync and have pieces missing. Why isn't it possible to use make check ? If there is something missing from there, then it's probably a better idea to modify it to do what it's not doing properly now rather than create a list of test to maintain.

Yes, I need it to do ./src/test/test_bitcoin --log_format=JUNIT > test_bitcoin.xml

When you have some time maybe you can help me figure out how to do this.

deadalnix accepted this revision.Apr 27 2018, 23:40

Ok, please make a task about this. In the meantime, we can do as this.

This revision is now accepted and ready to land.Apr 27 2018, 23:40
teamcity added a comment.May 2 2018, 18:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 2 2018, 18:18

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2309: Diff 3496!May 2 2018, 18:18
Closed by commit rABC45ba86437b58: Ensure teamcity runs more of the unit tests. (authored by schancel). · Explain WhyMay 3 2018, 01:53
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
27 lines

Diff 3496

View Options

contrib/teamcity/build.sh

Loading...