Check CI build results
Details
- Reviewers
deadalnix jasonbcox mbhinder - Group Reviewers
Restricted Project - Commits
- rSTAGING45ba86437b58: Ensure teamcity runs more of the unit tests.
rABC45ba86437b58: Ensure teamcity runs more of the unit tests.
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
1/ What about leveldb ?
2/ This doesn't seems like it'll fail if tests or even the build fails
It is "set -e" at the top, I believe it'll fail?
@schancel The code LGTM, don't have context about what it is supposed to cover.
Leveldb seems to be built in a strange way. No makefiles are being generated by ../configure
This approach is wrong, the leveldb thing was kind of a tell. This will lead to have to maintain a list of tests that will inevitably get out of sync and have pieces missing. Why isn't it possible to use make check ? If there is something missing from there, then it's probably a better idea to modify it to do what it's not doing properly now rather than create a list of test to maintain.
Yes, I need it to do ./src/test/test_bitcoin --log_format=JUNIT > test_bitcoin.xml
When you have some time maybe you can help me figure out how to do this.