Page MenuHomePhabricator
Differential D12809

Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code
ClosedPublic
Actions

Authored by PiRK on Dec 8 2022, 08:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC62b61aba6a01: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code
Summary

This is a backport of core#25148

Depends on D12784

Notes:

  • there is one more occurence of NO_THREAD_SAFETY_ANALYSIS in avalanche/processor.cpp
  • CWallet::IsSpent and CWallet::ReacceptWalletTransaction already had the annotation, so I also added the assertion (this is still not done on Core's master branch)
Test Plan

With Debug and TSAN

ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 8 2022, 08:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 8 2022, 08:09
PiRK requested review of this revision.Dec 8 2022, 08:09
teamcity edited the summary of this revision. (Show Details)Dec 8 2022, 08:09
PiRK planned changes to this revision.Dec 8 2022, 08:11

Wrong branch. needs rebasing on D12784

Harbormaster completed remote builds in B21455: Diff 37102.Dec 8 2022, 08:25
PiRK requested review of this revision.Dec 8 2022, 08:30

No actually this is the right branch.

PiRK added a comment.Dec 8 2022, 08:31

@bot build-tsan

teamcity awarded a token.Dec 8 2022, 08:31
PiRK mentioned this in D12784: refactor: Detach wallet transaction methods (followup for move-only).Dec 8 2022, 08:34
PiRK updated this revision to Diff 37105.Dec 8 2022, 08:55

rebase

Harbormaster completed remote builds in B21458: Diff 37105.Dec 8 2022, 09:11
Fabien requested changes to this revision.Dec 8 2022, 12:08
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
3129 ↗(On Diff #37105)

Needs the lock assertion

This revision now requires changes to proceed.Dec 8 2022, 12:08
PiRK updated this revision to Diff 37127.Dec 8 2022, 12:45

add missed lock assertion

Harbormaster completed remote builds in B21477: Diff 37127.Dec 8 2022, 13:38
Fabien accepted this revision.Dec 8 2022, 14:29
This revision is now accepted and ready to land.Dec 8 2022, 14:29
Closed by commit rABC62b61aba6a01: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyDec 8 2022, 15:05
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC62b61aba6a01: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code.

Revision Contents
Changeset List

PathSize
src/
wallet/
7 lines
21 lines
8 lines
3 lines
34 lines
12 lines

Diff 37130

View Options

src/wallet/interfaces.cpp

Loading...
View Options

src/wallet/receive.h

Loading...
View Options

src/wallet/receive.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...