Paths

Table of Contentst

Differential D12809

Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code
ClosedPublic
Actions

Authored by PiRK on Dec 8 2022, 08:09.

Tags

None

Subscribers

Tokens

"Haypence" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC62b61aba6a01: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code

Summary

This is a backport of core#25148

Depends on D12784

Notes:

there is one more occurence of NO_THREAD_SAFETY_ANALYSIS in avalanche/processor.cpp
CWallet::IsSpent and CWallet::ReacceptWalletTransaction already had the annotation, so I also added the assertion (this is still not done on Core's master branch)

Test Plan

With Debug and TSAN

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr22100_2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21458
Build 42565: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 42564: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 8 2022, 08:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 8 2022, 08:09

PiRK requested review of this revision.Dec 8 2022, 08:09

teamcity edited the summary of this revision. (Show Details)Dec 8 2022, 08:09

Wrong branch. needs rebasing on D12784

Harbormaster completed remote builds in B21455: Diff 37102.Dec 8 2022, 08:25

No actually this is the right branch.

@bot build-tsan

teamcity awarded a token.Dec 8 2022, 08:31

PiRK mentioned this in D12784: refactor: Detach wallet transaction methods (followup for move-only).Dec 8 2022, 08:34

rebase

Harbormaster completed remote builds in B21458: Diff 37105.Dec 8 2022, 09:11

Fabien requested changes to this revision.Dec 8 2022, 12:08

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/wallet/wallet.cpp
3129	Needs the lock assertion

This revision now requires changes to proceed.Dec 8 2022, 12:08

add missed lock assertion

Harbormaster completed remote builds in B21477: Diff 37127.Dec 8 2022, 13:38

Fabien accepted this revision.Dec 8 2022, 14:29

This revision is now accepted and ready to land.Dec 8 2022, 14:29

Closed by commit rABC62b61aba6a01: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyDec 8 2022, 15:05

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC62b61aba6a01: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code.

Revision Contents
Changeset List

Path

Size

src/

wallet/

7 lines

21 lines

8 lines

3 lines

34 lines

10 lines

Diff 37105

src/wallet/interfaces.cpp

Loading...

src/wallet/receive.h

Loading...

src/wallet/receive.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/wallet.h

Loading...

src/wallet/wallet.cpp

Loading...