Page MenuHomePhabricator

remove integer sanitizer suppression in validation.cpp
ClosedPublic

Authored by PiRK on Dec 8 2022, 12:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC295dde9e88bc: remove integer sanitizer suppression in validation.cpp
Summary

While looking at backporting core#24196, I noticed that the offending code was already changed in D359 (unsigned int -> size_t) and fixed in D1528 (removal of the for (size_t j = tx.vin.size(); j-- > 0;) loop)

Removing the file-wide suppression means that new UB can now be detected.

Test Plan

With UBSAN
ninja && ninja check check-functional

Diff Detail