Page MenuHomePhabricator

[Part 5] Refactor logging code into a global object
ClosedPublic

Authored by jimpo on Apr 12 2018, 19:51.

Details

Summary

Cleanup. Remove dependencies on utilstrencodings and boost/mutex.

Test Plan

Run bitcoind with different permutations of:
-logtimestamps, -debug, -printtoconsole, -datadir, -shrinkdebugfile

Diff Detail

Repository
rABC Bitcoin ABC
Branch
logging
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/init.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2301
Build 2740: Bitcoin ABC Buildbot (legacy)
Build 2739: arc lint + arc unit

Event Timeline

  • logging: Remove use of ARRAYLEN from utilstrencodings.
  • logging: Change boost::mutex to std::mutex.
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/logging.cpp
101 ↗(On Diff #3641)

I had no idea this worked on C style arrays.

This revision is now accepted and ready to land.May 1 2018, 00:04
This revision was automatically updated to reflect the committed changes.