Page MenuHomePhabricator
Differential D1284

[Part 5] Refactor logging code into a global object
ClosedPublic
Actions

Authored by jimpo on Apr 12 2018, 19:51.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGbc24189fbecf: [Part 5] Refactor logging code into a global object
rABCbc24189fbecf: [Part 5] Refactor logging code into a global object
Summary

Cleanup. Remove dependencies on utilstrencodings and boost/mutex.

Test Plan

Run bitcoind with different permutations of:
-logtimestamps, -debug, -printtoconsole, -datadir, -shrinkdebugfile

Diff Detail

Repository
rABC Bitcoin ABC
Branch
logging
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/init.cpp:1CFMTCode style violation
Auto-Fixsrc/qt/transactiondesc.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2337
Build 2811: Bitcoin ABC Buildbot (legacy)
Build 2810: arc lint + arc unit

Event Timeline

jimpo created this revision.Apr 12 2018, 19:51
jimpo added a parent revision: D1283: [Part 4] Refactor logging code into a global object.Apr 12 2018, 19:52
teamcity added a subscriber: teamcity.Apr 12 2018, 20:06

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster failed remote builds in B2301: Diff 3486!Apr 12 2018, 20:18
teamcity added a comment.Apr 12 2018, 20:18

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

jimpo mentioned this in D1283: [Part 4] Refactor logging code into a global object.Apr 14 2018, 19:19
jimpo updated this revision to Diff 3532.Apr 17 2018, 07:51

Rebased.

teamcity added a comment.Apr 17 2018, 08:26

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 17 2018, 08:40

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2337: Diff 3532.Apr 17 2018, 08:58
teamcity added a comment.Apr 17 2018, 08:58

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

jimpo updated this revision to Diff 3641.Apr 30 2018, 18:12
  • logging: Remove use of ARRAYLEN from utilstrencodings.
  • logging: Change boost::mutex to std::mutex.
jimpo edited the summary of this revision. (Show Details)Apr 30 2018, 18:13
teamcity added a comment.Apr 30 2018, 18:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 30 2018, 18:31

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2412: Diff 3641.Apr 30 2018, 18:31
deadalnix accepted this revision.May 1 2018, 00:04
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/logging.cpp
101 ↗(On Diff #3641)

I had no idea this worked on C style arrays.

This revision is now accepted and ready to land.May 1 2018, 00:04
Closed by commit rABCbc24189fbecf: [Part 5] Refactor logging code into a global object (authored by jimpo). · Explain WhyMay 1 2018, 01:35
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
12 lines
4 lines
20 lines
qt/
2 lines

Diff 3532

View Options

src/init.cpp

Loading...
View Options

src/logging.h

Loading...
View Options

src/logging.cpp

Loading...
View Options

src/qt/transactiondesc.cpp

Loading...