Fixes T312. 0x0 and 0x001 are examples of hex values that fail the script parser. This isn't immediately obvious unless you're familiar with the code, and the script fails with a totally useless and generic error message.
Details
Details
- Reviewers
deadalnix schancel - Group Reviewers
Restricted Project - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rSTAGING16c4d349cdde: Give more descriptive error when parsing partial-byte hex values
rABC16c4d349cdde: Give more descriptive error when parsing partial-byte hex values
make check + make check with script_tests.json having one line changed 0x02 -> 0x2 (fails with the expected error)
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/core_read.cpp | ||
|---|---|---|
| 73–75 ↗ | (On Diff #3512) | Uh. The linter did this. I wasn't aware this is valid C++. I looked it up and it may not be supported on older compilers. Let me know if you'd prefer that I add backslashes to concatenate them. |
| src/test/CMakeLists.txt | ||
|---|---|---|
| 72 ↗ | (On Diff #3519) | I missed it. I'm an idiot. |