Page MenuHomePhabricator
Differential D1301

Make PUSHDATA opcodes have names in ParseScript
ClosedPublic
Actions

Authored by schancel on Apr 20 2018, 21:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGfa7f0bba1284: Make PUSHDATA opcodes have names in ParseScript
rABCfa7f0bba1284: Make PUSHDATA opcodes have names in ParseScript
Summary

Currently, ParseScript does not recognize scripts which use the
full PUSHDATA opcode names. This commit enables the parser to
recognize these opcodes, and fixes script_tests.json to have
PUSHDATA opcodes be explicitly named.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Apr 20 2018, 21:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2018, 21:18
deadalnix accepted this revision.Apr 20 2018, 21:21
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/test/data/script_tests.json
578 ↗(On Diff #3558)

Remove extra space

This revision is now accepted and ready to land.Apr 20 2018, 21:21
schancel updated this revision to Diff 3561.Apr 20 2018, 21:27

Remove nit

teamcity added a subscriber: teamcity.Apr 20 2018, 21:36

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 20 2018, 21:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 20 2018, 22:11

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Apr 20 2018, 22:11

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2357: Diff 3558.Apr 20 2018, 22:11
teamcity added a comment.Apr 20 2018, 22:26

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 20 2018, 22:42

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 20 2018, 23:00

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2360: Diff 3561.Apr 20 2018, 23:00
schancel added a child revision: D1295: Ensure checks are enforced in core_read.cpp for all push types.Apr 23 2018, 05:02
Closed by commit rABCfa7f0bba1284: Make PUSHDATA opcodes have names in ParseScript (authored by schancel). · Explain WhyApr 24 2018, 04:58
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
93 lines
test/
3922 lines
data/
44 lines

Diff 3582

View Options

src/core_read.cpp

Loading...
View Options

src/test/core_io_tests.cpp

Loading...
View Options

src/test/data/script_tests.json

Loading...