Differential D12967

[avalanche] Make the GetAvalancheVoteForBlock method const
ClosedPublic
Actions

Authored by Fabien on Jan 10 2023, 14:30.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCffafe17dc244: [avalanche] Make the GetAvalancheVoteForBlock method const

Summary

Getting a vote should not change the PeerManager, so enforce it by marking it const.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_vote_for_block_const

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21723
Build 43085: Build Diff	lint-circular-dependencies · build-debug · build-clang-tidy · build-diff · build-without-wallet · build-clang
Build 43084: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 10 2023, 14:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2023, 14:30

Fabien requested review of this revision.Jan 10 2023, 14:30

Harbormaster completed remote builds in B21723: Diff 37500.Jan 10 2023, 14:43

PiRK accepted this revision.Jan 10 2023, 15:42

This revision is now accepted and ready to land.Jan 10 2023, 15:42

Closed by commit rABCffafe17dc244: [avalanche] Make the GetAvalancheVoteForBlock method const (authored by Fabien). · Explain WhyJan 10 2023, 16:39

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCffafe17dc244: [avalanche] Make the GetAvalancheVoteForBlock method const.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

5 lines

Diff 37500

View Options

[avalanche] Make the GetAvalancheVoteForBlock method constClosedPublicActions