Page MenuHomePhabricator
Differential D13232

[alias-server] Support for reserved ABC aliases
ClosedPublic
Actions

Authored by bytesofman on Mar 3 2023, 16:41.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCc22b91339173: [alias-server] Support for reserved ABC aliases
Summary

T2962

Add an array of reserved aliases that resolve to the alias registration address

Test Plan

Review new functions and mocks. Note that abc was a previously valid registered alias but is now invalidated by the reserved alias.
npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-server-whitelist
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22249
Build 44133: Build Diff
Build 44132: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 3 2023, 16:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2023, 16:41
bytesofman requested review of this revision.Mar 3 2023, 16:41
Harbormaster completed remote builds in B22247: Diff 38279.Mar 3 2023, 16:41
bytesofman updated this revision to Diff 38280.Mar 3 2023, 16:46

Revert debug changes, default reserved blockheight from 0 to 1 to avoid 'unconfirmed' ambiguity

Harbormaster completed remote builds in B22248: Diff 38280.Mar 3 2023, 16:46
bytesofman updated this revision to Diff 38281.Mar 3 2023, 16:47

Remove spacing change

Harbormaster completed remote builds in B22249: Diff 38281.Mar 3 2023, 16:47
bytesofman added a child revision: D13233: [alias-server] Telegram bot to announce new alias registrations.Mar 3 2023, 19:43
emack requested changes to this revision.Mar 4 2023, 04:11
emack added a subscriber: emack.
emack added inline comments.
web/alias-server/config.js
40

Once D13236 lands update this to directly reference the existing list in the codebase.

This revision now requires changes to proceed.Mar 4 2023, 04:11
bytesofman updated this revision to Diff 38292.Mar 4 2023, 18:04

Update mocks and unit tests

Harbormaster completed remote builds in B22257: Diff 38292.Mar 4 2023, 18:04
bytesofman added inline comments.Mar 4 2023, 18:05
web/alias-server/config.js
40

To make sure each app is self contained, we will probably keep these arrays in each repo (one in Cashtab, and one in alias-server).

We will need to add some kind of linting check to make sure they are always equivalent.

emack accepted this revision.Mar 5 2023, 00:44
This revision is now accepted and ready to land.Mar 5 2023, 00:44
Closed by commit rABCc22b91339173: [alias-server] Support for reserved ABC aliases (authored by bytesofman). · Explain WhyMar 5 2023, 03:59
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCc22b91339173: [alias-server] Support for reserved ABC aliases.

Revision Contents
Changeset List

PathSize
web/
alias-server/
18 lines
1 line
test/
mocks/
25 lines
32 lines
5 lines
17 lines

Diff 38281

View Options

web/alias-server/alias.js

Loading...
View Options

web/alias-server/config.js

Loading...
View Options

web/alias-server/test/mocks/aliasMocks.js

Loading...
View Options

web/alias-server/test/mocks/reservedAliasTxs.js

Loading...
View Options

web/alias-server/test/utils.js

Loading...
View Options

web/alias-server/utils.js

Loading...