Page MenuHomePhabricator

[alias-server] Support for reserved ABC aliases
ClosedPublic

Authored by bytesofman on Mar 3 2023, 16:41.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCc22b91339173: [alias-server] Support for reserved ABC aliases
Summary

T2962

Add an array of reserved aliases that resolve to the alias registration address

Test Plan

Review new functions and mocks. Note that abc was a previously valid registered alias but is now invalidated by the reserved alias.
npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22257
Build 44149: Build Diff
Build 44148: arc lint + arc unit

Event Timeline

Revert debug changes, default reserved blockheight from 0 to 1 to avoid 'unconfirmed' ambiguity

emack requested changes to this revision.Mar 4 2023, 04:11
emack added a subscriber: emack.
emack added inline comments.
web/alias-server/config.js
40 ↗(On Diff #38281)

Once D13236 lands update this to directly reference the existing list in the codebase.

This revision now requires changes to proceed.Mar 4 2023, 04:11

Update mocks and unit tests

web/alias-server/config.js
40 ↗(On Diff #38281)

To make sure each app is self contained, we will probably keep these arrays in each repo (one in Cashtab, and one in alias-server).

We will need to add some kind of linting check to make sure they are always equivalent.

This revision is now accepted and ready to land.Mar 5 2023, 00:44