Page MenuHomePhabricator
Differential D13385

[alias-server] Deprecate pendingAliases from getValidAliasRegistrations
AbandonedPublic
Actions

Authored by bytesofman on Mar 17 2023, 22:53.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Summary

T3011

Depends on D13384

pendingAliases will be parsed from the websocket and entered into a separate database. It didn't really make sense to look for pendingAliases with a function called on block confirmed. Get rid of this.

Test Plan

Review changes to expected output of function return and hence changes to unit tests, live script.
npm test and all pass
npm run live and all pass

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22769
Build 45158: Build Diff
Build 45157: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 17 2023, 22:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2023, 22:53
bytesofman requested review of this revision.Mar 17 2023, 22:53
Harbormaster completed remote builds in B22533: Diff 38687.Mar 17 2023, 22:53
bytesofman added a child revision: D13390: [alias-server] Clean up and apply feedback on reviews earlier in stack.Mar 18 2023, 04:18
emack requested changes to this revision.Mar 25 2023, 05:33
emack added a subscriber: emack.

same npm run live issue as per log shared in tg or D13361 just then, will pause reviews on this stack until we figure that out

This revision now requires changes to proceed.Mar 25 2023, 05:33
bytesofman updated this revision to Diff 38958.Mar 27 2023, 21:31

rebase

Harbormaster completed remote builds in B22752: Diff 38958.Mar 27 2023, 21:31
bytesofman updated this revision to Diff 38975.Mar 27 2023, 23:17

Accidentally removed support from aliasTestsLive here during last rebase

Harbormaster completed remote builds in B22769: Diff 38975.Mar 27 2023, 23:17
emack accepted this revision.Mar 28 2023, 23:29
This revision is now accepted and ready to land.Mar 28 2023, 23:29
bytesofman abandoned this revision.Mar 30 2023, 15:53

Revision Contents
Changeset List

PathSize
web/
alias-server/
6 lines
scripts/
15 lines
8 lines
test/
21 lines

Diff 38975

View Options

web/alias-server/alias.js

Loading...
View Options

web/alias-server/scripts/aliasTestsLive.js

Loading...
View Options

web/alias-server/scripts/generateMocks.js

Loading...
View Options

web/alias-server/test/alias.js

Loading...