[alias-server] Clean up and apply feedback on reviews earlier in stack
AbandonedPublic
Actions

Authored by bytesofman on Mar 18 2023, 04:18.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Summary

T2966

Depends on D13385

Remove comments that are no longer applicable to working of the app

Test Plan

Confirm only comments removed
npm test
npm run live

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22770
Build 45160: Build Diff
Build 45159: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 18 2023, 04:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2023, 04:18

bytesofman requested review of this revision.Mar 18 2023, 04:18

Harbormaster completed remote builds in B22538: Diff 38692.Mar 18 2023, 04:18

bytesofman added a child revision: D13396: [alias-server] Store pending alias txs in database, viewable at api endpoint.Mar 20 2023, 21:24

rebase

Harbormaster completed remote builds in B22753: Diff 38959.Mar 27 2023, 21:31

rebase

Harbormaster completed remote builds in B22770: Diff 38976.Mar 27 2023, 23:18

emack accepted this revision.Mar 28 2023, 23:30

This revision is now accepted and ready to land.Mar 28 2023, 23:30

bytesofman abandoned this revision.Mar 30 2023, 15:52

Revision Contents
Changeset List

Path

Size

web/

alias-server/

websocket.js

16 lines

Diff 38976

View Options

web/alias-server/websocket.js

[alias-server] Clean up and apply feedback on reviews earlier in stackAbandonedPublicActions