Differential D13440

Improve the mempool check method
ClosedPublic
Actions

Authored by Fabien on Mar 23 2023, 15:29.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC03a6478d0f60: Improve the mempool check method

Summary

This makes the mempool check more readable, especially by using better names than it1, it2, it3 etc. and by not reusing the names through the method.
There is no change in behavior.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 23 2023, 15:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 23 2023, 15:29

Fabien requested review of this revision.Mar 23 2023, 15:29

Harbormaster completed remote builds in B22621: Diff 38798.Mar 23 2023, 15:43

Fabien added a child revision: D13443: Migrate the mempool to hold shared pointers.Mar 23 2023, 16:24

PiRK accepted this revision.Mar 24 2023, 07:08

This revision is now accepted and ready to land.Mar 24 2023, 07:08

Closed by commit rABC03a6478d0f60: Improve the mempool check method (authored by Fabien). · Explain WhyMar 24 2023, 08:27

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC03a6478d0f60: Improve the mempool check method.

Revision Contents
Changeset List

Path

Size

src/

txmempool.cpp

98 lines

Diff 38821

View Options

Improve the mempool check methodClosedPublicActions