Page MenuHomePhabricator
Differential D13556

[Lint] Also catch `log!` and `log_chronik!` in .rs files in LogLinter
ClosedPublic
Actions

Authored by tobias_ruck on Apr 4 2023, 09:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7dda6c4dfaab: [Lint] Also catch `log!` and `log_chronik!` in .rs files in LogLinter
Summary

Missing \n at the end of log! and log_chronik! macro invocations in Rust files are now reported by LogLint.

Since string literals in Rust are allowed to contain newline characters, we need to insert a \s into the regex.

Test Plan
  1. Remove the 4 \n in chronik-http/error.rs
  2. arc lint
  3. 4 errors are emitted

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-lint-logs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22942
Build 45504: Build Diff
Build 45503: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 4 2023, 09:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 4 2023, 09:41
tobias_ruck requested review of this revision.Apr 4 2023, 09:41
Harbormaster completed remote builds in B22942: Diff 39203.Apr 4 2023, 09:41
tobias_ruck updated this revision to Diff 39224.Apr 4 2023, 13:51

Fix regex to catch false negatives

Harbormaster completed remote builds in B22954: Diff 39224.Apr 4 2023, 13:51
Fabien accepted this revision.Apr 4 2023, 13:51
This revision is now accepted and ready to land.Apr 4 2023, 13:51
tobias_ruck edited the summary of this revision. (Show Details)Apr 4 2023, 13:53
tobias_ruck edited the test plan for this revision. (Show Details)
tobias_ruck retitled this revision from [Lint] Also catch `log!` and `log_chronik!` in .rs files to LogLinter to [Lint] Also catch `log!` and `log_chronik!` in .rs files in LogLinter.
Closed by commit rABC7dda6c4dfaab: [Lint] Also catch `log!` and `log_chronik!` in .rs files in LogLinter (authored by tobias_ruck). · Explain WhyApr 4 2023, 13:55
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC7dda6c4dfaab: [Lint] Also catch `log!` and `log_chronik!` in .rs files in LogLinter.
tobias_ruck mentioned this in D13565: [Lint] Lint everything, apply some of the patches.Apr 4 2023, 15:57
tobias_ruck mentioned this in rABCaa4628e798c3: [Lint] Lint everything, apply some of the patches.Apr 4 2023, 16:26

Revision Contents
Changeset List

PathSize
2 lines
arcanist/
linter/
3 lines

Diff 39203

View Options

.arclint

Loading...
View Options

arcanist/linter/LogLinter.php

Loading...