[Cashtab] [Alias] Confirmation modal on registration
ClosedPublic
Actions

Authored by emack on Apr 5 2023, 13:52.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCf5fd748f4201: [Cashtab] [Alias] Confirmation modal on registration

Summary

T3028

Adds a confirmation modal upon clicking the Register Alias button.

Test Plan

enable alias in ticker.js
npm start
attempt to register a new alias, observe the modal is displayed to confirm both the alias input and the registration fee
click on cancel and ensure modal is closed with no further processing
click on ok and ensure the alias is registered
attempt to register an existing alias, click ok on the confirmation modal, and ensure the duplicate alias error is displayed

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Apr 5 2023, 13:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2023, 13:52

emack requested review of this revision.Apr 5 2023, 13:52

emack edited the summary of this revision. (Show Details)Apr 5 2023, 13:57

Harbormaster completed remote builds in B22997: Diff 39290.Apr 5 2023, 14:02

Run npm test and update snapshots (husky has been deprecated from this repo due to other complications)

This revision now requires changes to proceed.Apr 5 2023, 22:54

In D13583#302227, @bytesofman wrote:

Run npm test and update snapshots (husky has been deprecated from this repo due to other complications)

tried npm test and it doesn't deem this diff to warrant a snapshot update.

also tried to manually trigger snapshot update via npm test -- -u but same outcome.

In D13583#302403, @emack wrote:

In D13583#302227, @bytesofman wrote:

Run npm test and update snapshots (husky has been deprecated from this repo due to other complications)

tried npm test and it doesn't deem this diff to warrant a snapshot update.

also tried to manually trigger snapshot update via npm test -- -u but same outcome.