T3028
Adds a confirmation modal upon clicking the Register Alias button.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABCf5fd748f4201: [Cashtab] [Alias] Confirmation modal on registration
- enable alias in ticker.js
- npm start
- attempt to register a new alias, observe the modal is displayed to confirm both the alias input and the registration fee
- click on cancel and ensure modal is closed with no further processing
- click on ok and ensure the alias is registered
- attempt to register an existing alias, click ok on the confirmation modal, and ensure the duplicate alias error is displayed
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- aliasRegModal
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 22997 Build 45614: Build Diff cashtab-tests Build 45613: arc lint + arc unit
Event Timeline
Comment Actions
Run npm test and update snapshots (husky has been deprecated from this repo due to other complications)
Comment Actions
tried npm test and it doesn't deem this diff to warrant a snapshot update.
also tried to manually trigger snapshot update via npm test -- -u but same outcome.
Comment Actions
tried npm test and it doesn't deem this diff to warrant a snapshot update.
also tried to manually trigger snapshot update via npm test -- -u but same outcome.
probably since i ran npm test after changing the aliasEnabled flag in Ticker.js. so no change needed in the diff.