Page MenuHomePhabricator
Differential D13624

[tg bot] Improve how mocks are generated and stored
ClosedPublic
Actions

Authored by bytesofman on Apr 7 2023, 22:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf842e2dbcd76: [tg bot] Improve how mocks are generated and stored
Summary

T2972

Depends on D13623

It's been a persistent headache that generateMocks uses slightly different syntax / functions than what is used in the app. Some differences are necessary to preserve blockNames, which are useful in developer review and keeping track of why some blocks are mocked. But, in general, we want to be sure that the mocks are generated in exactly the same way that the app is running.

This diff refactors generateMocks to use the new handleBlockConnected function, modified with an optional flag to return mocks.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-refactor-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23092
Build 45804: Build Diffecash-herald-tests
Build 45803: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 7 2023, 22:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2023, 22:32
bytesofman requested review of this revision.Apr 7 2023, 22:32
Harbormaster completed remote builds in B23092: Diff 39417.Apr 7 2023, 22:33
bytesofman added a child revision: D13625: [herald] Fix instantiation of new telegramBot mock in websocket unit tests.Apr 7 2023, 22:34
Fabien requested changes to this revision.Apr 9 2023, 07:05
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/ecash-herald/scripts/generateMocks.js
138

it's no big deal if we don't have the copyright notice on test data (this is not code we need to protect) but add a @generated mark

This revision now requires changes to proceed.Apr 9 2023, 07:05
bytesofman updated this revision to Diff 39487.Apr 10 2023, 16:19

Adding @geneated to mock

Harbormaster completed remote builds in B23152: Diff 39487.Apr 10 2023, 16:19
bytesofman marked an inline comment as done.Apr 10 2023, 16:20
bytesofman added inline comments.
apps/ecash-herald/scripts/generateMocks.js
138

Added @generated

Leaving the header as it's more complicated to remove this lint rule for just this file than to keep it generally

bytesofman updated this revision to Diff 39499.Apr 10 2023, 16:31
bytesofman marked an inline comment as done.

rebase

Harbormaster completed remote builds in B23164: Diff 39499.Apr 10 2023, 16:31
Fabien accepted this revision.Apr 10 2023, 18:56
This revision is now accepted and ready to land.Apr 10 2023, 18:56
Closed by commit rABCf842e2dbcd76: [tg bot] Improve how mocks are generated and stored (authored by bytesofman). · Explain WhyApr 12 2023, 14:26
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCf842e2dbcd76: [tg bot] Improve how mocks are generated and stored.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
scripts/
83 lines
src/
8 lines
20 lines
test/
19 lines
mocks/
84 lines
13 lines
19 lines

Diff 39417

View Options

apps/ecash-herald/scripts/generateMocks.js

Loading...
View Options

apps/ecash-herald/src/events.js

Loading...
View Options

apps/ecash-herald/src/utils.js

Loading...
View Options

apps/ecash-herald/test/eventsTests.js

Loading...
View Options

apps/ecash-herald/test/mocks/blocks.js

Loading...
View Options

apps/ecash-herald/test/parseTests.js

Loading...
View Options

apps/ecash-herald/test/websocketTests.js

Loading...