Page MenuHomePhabricator
Differential D13641

[herald] Improve getCoingeckoPrices to return tickers and ecash price first
ClosedPublic
Actions

Authored by bytesofman on Apr 8 2023, 17:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC96b3345039f7: [herald] Improve getCoingeckoPrices to return tickers and ecash price first
Summary

T2972

Depends on D13640

Improve getCoingeckoPrices function to return ticker info of cryptos (required in tg msg). Make sure ecash price is returned first (helpful for making tg msgs). Add unit test.

Test Plan

Review changes to config and getCoingeckoPrices
npm test
npm run getCoingeckoPrices

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-refactor-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23118
Build 45856: Build Diffecash-herald-tests
Build 45855: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 8 2023, 17:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2023, 17:17
bytesofman requested review of this revision.Apr 8 2023, 17:17
Harbormaster completed remote builds in B23116: Diff 39441.Apr 8 2023, 17:18
bytesofman updated this revision to Diff 39442.Apr 8 2023, 17:22

Modifying getCoingeckoPrices script to support improvement

Harbormaster completed remote builds in B23117: Diff 39442.Apr 8 2023, 17:22
bytesofman updated this revision to Diff 39443.Apr 8 2023, 17:22

lint

bytesofman edited the test plan for this revision. (Show Details)Apr 8 2023, 17:22
Harbormaster completed remote builds in B23118: Diff 39443.Apr 8 2023, 17:23
bytesofman added a child revision: D13642: [herald] New formatPrice function to prep prices for tg msgs.Apr 8 2023, 17:27
Fabien accepted this revision.Apr 9 2023, 09:16
This revision is now accepted and ready to land.Apr 9 2023, 09:16
bytesofman updated this revision to Diff 39504.Apr 10 2023, 16:32

rebase

Harbormaster completed remote builds in B23169: Diff 39504.Apr 10 2023, 16:32
Closed by commit rABC96b3345039f7: [herald] Improve getCoingeckoPrices to return tickers and ecash price first (authored by bytesofman). · Explain WhyApr 12 2023, 14:26
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC96b3345039f7: [herald] Improve getCoingeckoPrices to return tickers and ecash price first.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
6 lines
scripts/
37 lines
src/
37 lines
test/
70 lines

Diff 39443

View Options

apps/ecash-herald/config.js

Loading...
View Options

apps/ecash-herald/scripts/getCoingeckoPrices.js

Loading...
View Options

apps/ecash-herald/src/utils.js

Loading...
View Options

apps/ecash-herald/test/utilsTests.js

Loading...