Page MenuHomePhabricator
Differential D13642

[herald] New formatPrice function to prep prices for tg msgs
ClosedPublic
Actions

Authored by bytesofman on Apr 8 2023, 17:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5e3c04ec7238: [herald] New formatPrice function to prep prices for tg msgs
Summary

T2972

Depends on D13641

Add new function to format price with correct fiat currency symbol, if available

Test Plan

npm test
npm run getCoingeckoPrices and note prices appear with currency symbol

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23170
Build 45959: Build Diff
Build 45958: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 8 2023, 17:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2023, 17:27
bytesofman requested review of this revision.Apr 8 2023, 17:27
Harbormaster completed remote builds in B23119: Diff 39444.Apr 8 2023, 17:28
bytesofman added a child revision: D13643: [herald] Add price info to sent tg msgs.Apr 8 2023, 17:54
Fabien requested changes to this revision.Apr 9 2023, 09:19
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/ecash-herald/src/utils.js
84 ↗(On Diff #39444)

10 seems a bit low, that's up to 10% error. 100 is more consistent with the error from 2 decimal places

This revision now requires changes to proceed.Apr 9 2023, 09:19
bytesofman updated this revision to Diff 39489.Apr 10 2023, 16:27

Round 2 decimal places if price < 100

Harbormaster completed remote builds in B23154: Diff 39489.Apr 10 2023, 16:27
bytesofman marked an inline comment as done.Apr 10 2023, 16:27
bytesofman updated this revision to Diff 39505.Apr 10 2023, 16:32

rebase

Harbormaster completed remote builds in B23170: Diff 39505.Apr 10 2023, 16:32
Fabien accepted this revision.Apr 10 2023, 19:11
This revision is now accepted and ready to land.Apr 10 2023, 19:11
Closed by commit rABC5e3c04ec7238: [herald] New formatPrice function to prep prices for tg msgs (authored by bytesofman). · Explain WhyApr 12 2023, 14:26
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC5e3c04ec7238: [herald] New formatPrice function to prep prices for tg msgs.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
1 line
scripts/
5 lines
src/
28 lines
test/
27 lines

Diff 39505

View Options

apps/ecash-herald/config.js

Loading...
View Options

apps/ecash-herald/scripts/getCoingeckoPrices.js

Loading...
View Options

apps/ecash-herald/src/utils.js

Loading...
View Options

apps/ecash-herald/test/utilsTests.js

Loading...