Page MenuHomePhabricator

Make the Amount constructor noexcept
ClosedPublic

Authored by Fabien on Apr 27 2023, 09:05.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC5d8279e3cc4b: Make the Amount constructor noexcept
Summary

Because it can't throw but that's not implied by constexpr. This fixes a build issue with clang8 that requires a noexcept constructor for the atomic, so we need that noexcept to build a std::atomic<Amount> which we do in net.h.

Test Plan

With clang 8:

ninja all check