This commit creates a typedef for handling mapDeltas in the mempool.
This exists to allow easy changes to the base type going forward.
Details
Details
- Reviewers
deadalnix jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING184cf2684319: Create a typedef for handling mapDeltas in the mempool.
rABC184cf2684319: Create a typedef for handling mapDeltas in the mempool.
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- arcpatch-D1383
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2859 Build 3822: Bitcoin ABC Buildbot (legacy) Build 3821: arc lint + arc unit
Event Timeline
| src/txmempool.h | ||
|---|---|---|
| 562 ↗ | (On Diff #3814) | WHy the rename ? Are going to have all the field named m_somethingnow ? |
| src/txmempool.h | ||
|---|---|---|
| 562 ↗ | (On Diff #3814) | That's what we agreed in the style guide. |
| src/txmempool.h | ||
|---|---|---|
| 562 ↗ | (On Diff #3814) | That's ugly and doesn't match existing style. |
| src/txmempool.h | ||
|---|---|---|
| 562 ↗ | (On Diff #3814) | The goal of a style guide is to make sure the codebase stay uniform, it's clearly not working here. |
| src/txmempool.h | ||
|---|---|---|
| 562 ↗ | (On Diff #3814) | The codebase is completely inconsistent right now. I proposed a standard, and it was accepted by people who cared. If you want to use a different standard you need to be vocal on the documentation itself. This was a middle ground that we all agreed to so we could know when the code was referring to a global, local, or member variable. |