Page MenuHomePhabricator

Create a typedef for handling mapDeltas in the mempool.
ClosedPublic

Authored by schancel on May 8 2018, 05:01.

Details

Summary

This commit creates a typedef for handling mapDeltas in the mempool.
This exists to allow easy changes to the base type going forward.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mapDeltaType
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2540
Build 3197: Bitcoin ABC Teamcity Staging
Build 3196: arc lint + arc unit

Event Timeline

schancel created this revision.May 8 2018, 05:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2018, 05:01
deadalnix added inline comments.
src/txmempool.h
562

WHy the rename ? Are going to have all the field named m_somethingnow ?

schancel added inline comments.May 8 2018, 22:47
src/txmempool.h
562

That's what we agreed in the style guide.

deadalnix added inline comments.May 9 2018, 11:51
src/txmempool.h
562

That's ugly and doesn't match existing style.

deadalnix added inline comments.May 9 2018, 11:56
src/txmempool.h
562

The goal of a style guide is to make sure the codebase stay uniform, it's clearly not working here.

schancel added inline comments.May 17 2018, 06:47
src/txmempool.h
562

The codebase is completely inconsistent right now. I proposed a standard, and it was accepted by people who cared.

If you want to use a different standard you need to be vocal on the documentation itself. This was a middle ground that we all agreed to so we could know when the code was referring to a global, local, or member variable.

deadalnix requested changes to this revision.Jun 18 2018, 23:58

Can you remove the m_ from m_txModifiers ? Beside that, it's all good.

This revision now requires changes to proceed.Jun 18 2018, 23:58
schancel updated this revision to Diff 4291.Jul 12 2018, 18:38

Change name of parameter back to mapDeltas

jasonbcox accepted this revision.Jul 13 2018, 18:39
deadalnix accepted this revision.Jul 14 2018, 23:55
This revision is now accepted and ready to land.Jul 14 2018, 23:55
schancel updated this revision to Diff 4361.Jul 20 2018, 17:23

Rebase to see if test is fixed?

This revision was automatically updated to reflect the committed changes.