Page MenuHomePhabricator

[lint] replace autopep8 with black (test_framework)
ClosedPublic

Authored by PiRK on May 11 2023, 07:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbeecd495d6d4: [lint] replace autopep8 with black (test_framework)
Summary

See D13876 for the description.

Depends on D13887

Test Plan

ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
autopep8_to_black
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23692
Build 46998: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 46997: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.May 11 2023, 07:24
test/functional/test_framework/ripemd160.py
11

This is probably the most controversial point of the black style.
We could add # fmt: off and # fmt: on around theses lists if this change is not desired.

Fabien requested changes to this revision.May 12 2023, 08:05
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/ripemd160.py
11

Yes in this case it's better to disable formatting.
No big deal if this has to be handled manually for the few special cases where it's needed

This revision now requires changes to proceed.May 12 2023, 08:05

disable formatting for long lists of integers

This revision is now accepted and ready to land.May 12 2023, 13:27