Paths

Table of Contentst

Differential D13888

[lint] replace autopep8 with black (test_framework)
ClosedPublic
Actions

Authored by PiRK on May 11 2023, 07:24.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCbeecd495d6d4: [lint] replace autopep8 with black (test_framework)

Summary

See D13876 for the description.

Depends on D13887

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

autopep8_to_black

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23692
Build 46998: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 46997: arc lint + arc unit

Event Timeline

PiRK created this revision.May 11 2023, 07:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2023, 07:24

PiRK requested review of this revision.May 11 2023, 07:24

PiRK added a child revision: D13889: [lint] replace autopep8 with black (everything but contrib).May 11 2023, 08:01

PiRK added inline comments.May 11 2023, 08:06

test/functional/test_framework/ripemd160.py
11	This is probably the most controversial point of the black style. We could add `# fmt: off` and `# fmt: on` around theses lists if this change is not desired.

Harbormaster completed remote builds in B23692: Diff 40277.May 11 2023, 08:21

Fabien requested changes to this revision.May 12 2023, 08:05

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/test_framework/ripemd160.py
11	Yes in this case it's better to disable formatting. No big deal if this has to be handled manually for the few special cases where it's needed

This revision now requires changes to proceed.May 12 2023, 08:05

disable formatting for long lists of integers

Harbormaster completed remote builds in B23697: Diff 40285.May 12 2023, 13:09

Fabien accepted this revision.May 12 2023, 13:27

This revision is now accepted and ready to land.May 12 2023, 13:27

Closed by commit rABCbeecd495d6d4: [lint] replace autopep8 with black (test_framework) (authored by PiRK). · Explain WhyMay 12 2023, 13:46

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCbeecd495d6d4: [lint] replace autopep8 with black (test_framework).

Revision Contents
Changeset List

Path

Size

4 lines

test/

functional/

data/

78 lines

test_framework/

79 lines

200 lines

180 lines

110 lines

71 lines

23 lines

18 lines

36 lines

124 lines

254 lines

61 lines

90 lines

311 lines

375 lines

538 lines

6 lines

25 lines

test_framework.py

415 lines

619 lines

20 lines

145 lines

140 lines

73 lines

Diff 40277

.arclint

Loading...

test/functional/data/invalid_txs.py

Loading...

test/functional/test_framework/address.py

Loading...

test/functional/test_framework/authproxy.py

Loading...

test/functional/test_framework/avatools.py

Loading...

test/functional/test_framework/blocktools.py

Loading...

test/functional/test_framework/cashaddr.py

Loading...

test/functional/test_framework/cdefs.py

Loading...

test/functional/test_framework/coverage.py

Loading...

test/functional/test_framework/descriptors.py

Loading...

test/functional/test_framework/key.py

Loading...

test/functional/test_framework/messages.py

Loading...

test/functional/test_framework/muhash.py

Loading...

test/functional/test_framework/netutil.py

Loading...

test/functional/test_framework/p2p.py

Loading...

test/functional/test_framework/ripemd160.py

Loading...

test/functional/test_framework/script.py

Loading...

test/functional/test_framework/siphash.py

Loading...

test/functional/test_framework/socks5.py

Loading...

test/functional/test_framework/test_framework.py

Loading...

test/functional/test_framework/test_node.py

Loading...

test/functional/test_framework/txtools.py

Loading...

test/functional/test_framework/util.py

Loading...

test/functional/test_framework/wallet.py

Loading...

test/functional/test_framework/wallet_util.py

Loading...