Adding back the background change on scroll functionality now that the page has more content to scroll.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABCad28fa97a8fe: [e.cash] Add navbar background change on scroll
@bot preview-e.cash
Scroll up and down the page and you should see navbar background change to an a darker background when you scroll down
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-navbar-background-change
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 23715 Build 47042: Build Diff Build 47041: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41521 for the next 60 minutes.
| web/e.cash/components/navbar/index.js | ||
|---|---|---|
| 12 ↗ | (On Diff #40316) | Initialize this as a number that meets the desired condition for on app load, so that there is no ambiguity with type changes In this case...'' does work. But better to useState(0) , which is also a number, as the height will be. |
| 45 ↗ | (On Diff #40316) | should end this line with a ; no? |
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41840 for the next 60 minutes.