Paths

Table of Contentst

Differential D13900

[e.cash] Add navbar background change on scroll
ClosedPublic
Actions

Authored by johnkuney on May 15 2023, 15:44.

Tags

None

Subscribers

Tokens

"Piece of Eight" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCad28fa97a8fe: [e.cash] Add navbar background change on scroll

Summary

Adding back the background change on scroll functionality now that the page has more content to scroll.

Test Plan

@bot preview-e.cash
Scroll up and down the page and you should see navbar background change to an a darker background when you scroll down

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

johnkuney created this revision.May 15 2023, 15:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 15 2023, 15:44

johnkuney requested review of this revision.May 15 2023, 15:44

Harbormaster completed remote builds in B23715: Diff 40315.May 15 2023, 15:44

add background color value to theme

Harbormaster completed remote builds in B23716: Diff 40316.May 15 2023, 15:47

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41521 for the next 60 minutes.

bytesofman requested changes to this revision.May 15 2023, 18:08

bytesofman added inline comments.

web/e.cash/components/navbar/index.js
12 ↗	(On Diff #40316)	Initialize this as a number that meets the desired condition for on app load, so that there is no ambiguity with type changes In this case...`''` does work. But better to `useState(0)` , which is also a number, as the height will be.
45 ↗	(On Diff #40316)	should end this line with a `;` no?

This revision now requires changes to proceed.May 15 2023, 18:08

Change initial state for window height, add ;

Harbormaster completed remote builds in B23717: Diff 40317.May 15 2023, 18:50

for sure, added

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41840 for the next 60 minutes.

bytesofman accepted this revision.May 15 2023, 21:34

This revision is now accepted and ready to land.May 15 2023, 21:34

Closed by commit rABCad28fa97a8fe: [e.cash] Add navbar background change on scroll (authored by johnkuney). · Explain WhyMay 15 2023, 23:02

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABCad28fa97a8fe: [e.cash] Add navbar background change on scroll.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

components/

navbar/

26 lines

11 lines

styles/

2 lines

Diff 40324

web/e.cash/components/navbar/index.js

Loading...

web/e.cash/components/navbar/styles.js

Loading...

web/e.cash/styles/theme.js

Loading...