Page MenuHomePhabricator

[e.cash] Add navbar background change on scroll
ClosedPublic

Authored by johnkuney on May 15 2023, 15:44.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCad28fa97a8fe: [e.cash] Add navbar background change on scroll
Summary

Adding back the background change on scroll functionality now that the page has more content to scroll.

Test Plan

@bot preview-e.cash
Scroll up and down the page and you should see navbar background change to an a darker background when you scroll down

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-navbar-background-change
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23716
Build 47044: Build Diff
Build 47043: arc lint + arc unit

Event Timeline

add background color value to theme

bytesofman added inline comments.
web/e.cash/components/navbar/index.js
12

Initialize this as a number that meets the desired condition for on app load, so that there is no ambiguity with type changes

In this case...'' does work. But better to useState(0) , which is also a number, as the height will be.

45

should end this line with a ; no?

This revision now requires changes to proceed.May 15 2023, 18:08

Change initial state for window height, add ;

This revision is now accepted and ready to land.May 15 2023, 21:34