Differential D14018

Move GroupOutputs into SelectCoinsMinConf
ClosedPublic
Actions

Authored by Fabien on Jun 8 2023, 21:01.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC399d24266641: Move GroupOutputs into SelectCoinsMinConf

Summary

This is a partial backport of core#20040:
https://github.com/bitcoin/bitcoin/pull/20040/commits/6148a8acda5e594bb9b3b2d989056f9e03ddbdbd

There is no change in behavior.

Depends on D14017.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 8 2023, 21:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2023, 21:01

Fabien requested review of this revision.Jun 8 2023, 21:01

teamcity edited the summary of this revision. (Show Details)Jun 8 2023, 21:01

Fabien added a child revision: D14019: Move fee setting of OutputGroup to Insert.Jun 8 2023, 21:01

Harbormaster completed remote builds in B23954: Diff 40668.Jun 8 2023, 21:28

PiRK accepted this revision.Jun 9 2023, 05:41

This revision is now accepted and ready to land.Jun 9 2023, 05:41

Closed by commit rABC399d24266641: Move GroupOutputs into SelectCoinsMinConf (authored by Andrew Chow <achow101-github@achow101.com>, committed by Fabien). · Explain WhyJun 9 2023, 05:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC399d24266641: Move GroupOutputs into SelectCoinsMinConf.

Revision Contents
Changeset List

Path

Size

src/

bench/

coin_selection.cpp

16 lines

wallet/

spend.h

2 lines

spend.cpp

29 lines

test/

coinselector_tests.cpp

228 lines

wallet.h

6 lines

Diff 40678

View Options

src/bench/coin_selection.cpp

View Options

src/wallet/spend.h

View Options

src/wallet/spend.cpp

View Options

src/wallet/test/coinselector_tests.cpp

View Options

Move GroupOutputs into SelectCoinsMinConfClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40678

src/bench/coin_selection.cpp

src/wallet/spend.h

src/wallet/spend.cpp

src/wallet/test/coinselector_tests.cpp

src/wallet/wallet.h

Move GroupOutputs into SelectCoinsMinConf
ClosedPublic
Actions

Revision Contents
Changeset List