Page MenuHomePhabricator

Remove tx chained limit from the coin selection algorithm
ClosedPublic

Authored by Fabien on Jun 8 2023, 21:27.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCbcd6dafcd35e: Remove tx chained limit from the coin selection algorithm
Summary

It's no longer relevant after wellington activation.

Depends on D14023.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jun 8 2023, 21:27

Tail of the build log:

[375/537] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[376/537] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[377/537] Linking CXX executable src/bitcoin-tx
[378/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[379/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[380/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[381/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[382/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[383/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[384/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[385/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[386/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[387/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[388/537] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[389/537] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[390/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[391/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/spend.cpp.o 
/usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-12;-warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=../../src/wallet/spend.cpp -- /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/spend.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/spend.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/spend.cpp.o -c ../../src/wallet/spend.cpp
/work/abc-ci-builds/build-clang-tidy/../../src/wallet/spend.cpp:578:42: error: argument name 'include_partial_groups' in comment does not match parameter name 'include_partial' [bugprone-argument-comment,-warnings-as-errors]
             CoinEligibilityFilter(0, 1, /*include_partial_groups=*/true),
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                                         /*include_partial=*/
../../src/./wallet/coinselection.h:72:32: note: 'include_partial' declared here
                          bool include_partial)
                               ^
/work/abc-ci-builds/build-clang-tidy/../../src/wallet/spend.cpp:584:42: error: argument name 'include_partial_groups' in comment does not match parameter name 'include_partial' [bugprone-argument-comment,-warnings-as-errors]
             CoinEligibilityFilter(0, 1, /*include_partial_groups=*/true),
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                                         /*include_partial=*/
../../src/./wallet/coinselection.h:72:32: note: 'include_partial' declared here
                          bool include_partial)
                               ^
3250 warnings generated.
Suppressed 3248 warnings (3248 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings treated as errors
[392/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[393/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[394/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[395/537] Linking CXX static library src/zmq/libzmq.a
[396/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[397/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[398/537] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[399/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[400/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[401/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[402/537] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[403/537] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[404/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[405/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[406/537] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[407/537] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[408/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[409/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[410/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[411/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[412/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
Fabien planned changes to this revision.Jun 9 2023, 05:51
This revision is now accepted and ready to land.Jun 9 2023, 06:30