T3060
With the spec solidified, these aren't really adjustable parameters. Will be permanent for prod version of app.
Move to /constants/ now to reflect this
Details
Details
- Reviewers
emack Fabien - Group Reviewers
Restricted Project - Commits
- rABCe75d5fb4354e: [alias-server] Move aliasConstants out of config and into constants dir
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- move-alias-constants
- Lint
Lint Errors Severity Location Code Message Error apps/alias-server/test/aliasTests.js:8 ESLINT no-unused-vars Error apps/alias-server/test/chronikWsHandlerTests.js:7 ESLINT no-unused-vars - Unit
No Test Coverage - Build Status
Buildable 24005 Build 47620: Build Diff alias-server-tests Build 47619: arc lint + arc unit
Event Timeline
Comment Actions
Should this be in package.json?
Even after npm i, I'm getting this when running npm test
Should this be in package.json?
npm audit fix didn't fix this dependency either
Comment Actions
Even after npm i, I'm getting this when running npm test
Should this be in package.json?npm audit fix didn't fix this dependency either
what's your output from node --version ?
Also, please include the whole stack trace of the error as text
Comment Actions
Even after npm i, I'm getting this when running npm test
Should this be in package.json?npm audit fix didn't fix this dependency either
what's your output from node --version ?
Also, please include the whole stack trace of the error as text
On further review, issue is prob that I created D14045 on master, so I probably created this one on top of that. Hence the dependencies would be different.
| apps/alias-server/constants/alias.js | ||
|---|---|---|
| 33 ↗ | (On Diff #40765) | I thought this was no longer a thing ? |
| apps/alias-server/constants/alias.js | ||
|---|---|---|
| 33 ↗ | (On Diff #40765) | it's been deprecated but I forgot to remove it from the constants It's completed in the diff stacked onto this |