[alias-server] Move aliasConstants out of config and into constants dir
ClosedPublic
Actions

Authored by bytesofman on Jun 12 2023, 17:22.

Details

Reviewers

emack
Fabien

Group Reviewers

Restricted Project

Commits

rABCe75d5fb4354e: [alias-server] Move aliasConstants out of config and into constants dir

Summary

T3060

With the spec solidified, these aren't really adjustable parameters. Will be permanent for prod version of app.

Move to /constants/ now to reflect this

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

move-alias-constants

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24006
Build 47622: Build Diff	alias-server-tests
Build 47621: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 12 2023, 17:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2023, 17:22

bytesofman requested review of this revision.Jun 12 2023, 17:22

Harbormaster completed remote builds in B24005: Diff 40738.Jun 12 2023, 17:22

lint

bytesofman added a child revision: D14047: [alias-server] Remove reserved aliases from aliasConstants.Jun 12 2023, 17:24

Harbormaster completed remote builds in B24006: Diff 40739.Jun 12 2023, 17:24

Even after npm i, I'm getting this when running npm test

Should this be in package.json?

npm audit fix didn't fix this dependency either

This revision now requires changes to proceed.Jun 13 2023, 00:15

In D14046#313656, @emack wrote:

Even after npm i, I'm getting this when running npm test

Should this be in package.json?

npm audit fix didn't fix this dependency either

what's your output from node --version ?

Also, please include the whole stack trace of the error as text

In D14046#313751, @bytesofman wrote:

In D14046#313656, @emack wrote:

Even after npm i, I'm getting this when running npm test

Should this be in package.json?

npm audit fix didn't fix this dependency either

what's your output from node --version ?

Also, please include the whole stack trace of the error as text

On further review, issue is prob that I created D14045 on master, so I probably created this one on top of that. Hence the dependencies would be different.

bytesofman edited the summary of this revision. (Show Details)Jun 13 2023, 16:32

bytesofman added a parent revision: D14045: [alias-server] Run npm audit fix to update dependencies.

bytesofman edited the summary of this revision. (Show Details)

rebase

ok issue should be fixed by this rebase

Harbormaster completed remote builds in B24021: Diff 40765.Jun 13 2023, 16:51

Fabien added a subscriber: Fabien.Jun 13 2023, 19:25

Fabien added inline comments.