Paths

Table of Contentst

Differential D14125

[cmake] move make_link function to a new MakeLink module
ClosedPublic
Actions

Authored by PiRK on Jun 26 2023, 10:20.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd54d03226b63: [cmake] move make_link function to a new MakeLink module

Summary

This function will be used also for electrum tests.

Test Plan

cmake .. -GNinja && ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 26 2023, 10:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 26 2023, 10:20

PiRK requested review of this revision.Jun 26 2023, 10:20

PiRK added a child revision: D14126: [electrum] add a check-electrum target.Jun 26 2023, 10:23

Harbormaster completed remote builds in B24179: Diff 40994.Jun 26 2023, 10:36

Fabien requested changes to this revision.Jun 26 2023, 15:17

Fabien added a subscriber: Fabien.

Fabien added inline comments.

cmake/modules/TestSuite.cmake
226 ↗	(On Diff #40994)	This is really not related to test suites at all, you should find a better place for this function (or create one)

This revision now requires changes to proceed.Jun 26 2023, 15:17

create a new cmake module for this function

Fabien accepted this revision.Jun 27 2023, 13:55

This revision is now accepted and ready to land.Jun 27 2023, 13:55

Harbormaster completed remote builds in B24198: Diff 41024.Jun 27 2023, 14:15

Closed by commit rABCd54d03226b63: [cmake] move make_link function to a new MakeLink module (authored by PiRK). · Explain WhyJun 27 2023, 19:22

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd54d03226b63: [cmake] move make_link function to a new MakeLink module.

Revision Contents
Changeset List

Path

Size

cmake/

modules/

MakeLink.cmake

25 lines

test/

CMakeLists.txt

27 lines

Diff 41042

View Options

cmake/modules/MakeLink.cmake